Add Cookie extractor for typed cookie access#139
Merged
arferreira merged 4 commits intomainfrom Feb 12, 2026
Merged
Conversation
juv
reviewed
Feb 10, 2026
| let json = serde_json::to_string(&cookies) | ||
| .map_err(|e| Error::bad_request(format!("Failed to process cookies: {}", e)))?; | ||
|
|
||
| let value: T = serde_json::from_str(&json) |
Collaborator
There was a problem hiding this comment.
Serializing to JSON and then deserializing from JSON to T looks interesting. Is this a good approach (genuinely asking)?
Owner
Author
There was a problem hiding this comment.
fair point! it's a pragmatic shortcut, cookies are always k/v pairs, so the json roundtrip works, but yeah it's not the ideal world, I think maybe a direct Hashmap<String, String> -> T would be cleaner, good candidate for a follow-up improvement.
juv
requested changes
Feb 10, 2026
Collaborator
juv
left a comment
juv
left a comment
There was a problem hiding this comment.
Missing changes to docs: https://github.com/arferreira/rapina/blob/main/docs/content/guide/extractors.md
uemuradevexe
approved these changes
Feb 12, 2026
juv
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cookie<T>extractor for deserializing cookies into typed structsCookieheader and deserialize to target type via serdeUsage
Related Issues
Closes #85
Checklist
cargo fmtpassescargo clippyhas no warnings